Repository navigation
minor: fix SYMFONY_REQUIRE wildcard in the code coverage job - #1165
Merged
Merged
Conversation
Flex rewrites "8.1.x" to "8.1.x-dev", which matches no symfony/symfony branch: it then silently stops restricting Symfony packages, and the job ended up testing a mix of Symfony versions. Claude-Session: https://claude.ai/code/session_01LwSqtXWbThCqudR6k7C6tK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code coverage job used
SYMFONY_REQUIRE: 8.1.x. Flex rewrites a trailing.xto.x-dev, which matches nosymfony/symfonybranch, so it silently stops restricting Symfony packages: the job installedsymfony/framework-bundle8.0.15 andsymfony/http-kernel7.4.18 next to 8.1 components (see this run, no "Restricting packages listed in symfony/symfony" line in the install log).8.1.*is the form Flex understands as a minor, like every other job.https://claude.ai/code/session_01LwSqtXWbThCqudR6k7C6tK